harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "deven you (JIRA)" <j...@apache.org>
Subject [jira] Created: (HARMONY-6461) [classlib][nio_char]Remove alias cache from Charset
Date Wed, 03 Mar 2010 09:41:27 GMT
[classlib][nio_char]Remove alias cache from Charset
---------------------------------------------------

                 Key: HARMONY-6461
                 URL: https://issues.apache.org/jira/browse/HARMONY-6461
             Project: Harmony
          Issue Type: Bug
    Affects Versions: 5.0M14
            Reporter: deven you
             Fix For: 5.0M14


At present, when a charset is loaded by a charset name, Charset class will cache all alias
of that charset. However it is not a good design because harmony use built-in charset provider
and third party providers. We can not ensure one alias only belongs to a unique charset which
provided by built-in or 3rd providers. Actually now harmony use built-in and icu provider
has already countered such problems with this design. Below charset alias belong to more than
one charset:
    TIS-620,
    windows-1258,
    cp856,
    cp922
Now Charset only solve this issue with hard code. I think the correct way to deal with this
situation is that when Charset load a charset with a charset name, it should only cache this
charset name and the canonical name of the charset, rather than cache all alias of that charset.
Follow this way the alias conflict will be solved and there is no need of any hard code anymore.
I have test this patch for many common benchmarks like specjvm2008, specjbb2005, volano and
dacapo. It shows there is no performance regression for this design change. So please someone
verify this patch. Thanks a lot!

  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message