harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6465) [classlib][nio]Small fixes according to the findbug results
Date Fri, 12 Mar 2010 14:41:27 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844521#action_12844521
] 

Tim Ellison commented on HARMONY-6465:
--------------------------------------

Thanks Charles, patch applied at repo revision r922278.

Please check it was applied as you expected.

Note that you can add FindBugs exclude filters to nio/make/findbugs-exclude-filter.xml  if
you determine they are false positives.


> [classlib][nio]Small fixes according to the findbug results
> -----------------------------------------------------------
>
>                 Key: HARMONY-6465
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6465
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: All
>            Reporter: Li Jing Qin
>            Assignee: Tim Ellison
>            Priority: Minor
>             Fix For: 5.0M14
>
>         Attachments: findbug-nio.diff, findbug-nio.diff
>
>
> According to the findbug results, this patch including simple fixes or refactors as follow:
> 1. Use Integer.valueOf instead of new Integer, which may use the Integer cached. (MappedByteBufferFactory.java)
> 2. Use the primitive 0L instead of the new Long(0). (SocketChannelImpl.java)
> 3. Change the final int to be a static field. (EpollSelectorImpl.java)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message