harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-6482) Implementation of getImageWriter, getImageReader
Date Fri, 26 Mar 2010 13:24:27 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Tim Ellison resolved HARMONY-6482.

       Resolution: Fixed
    Fix Version/s: 5.0M14

Thanks Lang.

I applied your patch with a couple of minor modifications to layout (tabs -> spaces, and
adding optional braces) so that the code matches the "house style".

I also modified two lines with a semi-colon that I think is a bug, please check:

+				if (readerSpi.getClass().getName().equals(readerSpiName));

this has an empty statement at the end.

I externalized the exception error string.

Please check you agree with the version committed at r927838.

If you have a JUnit test that shows this code working as expected, please send it along.

> Implementation of getImageWriter, getImageReader
> ------------------------------------------------
>                 Key: HARMONY-6482
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6482
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Tim Ellison
>             Fix For: 5.0M14
>         Attachments: HARMONY-6482-yanglang.txt
> I have implemented these methods
> javax.imageio.ImageIO.getImageReader()
> javax.imageio.ImageIO.getImageWriter()
> javax.imageio.spi.ImageReaderSpi.getImageWriterSpiNames()
> I only used the following Reader/Writer to test (Since they are the only available ones):
> ImageIO.getImageWriter(new JPEGImageReader(new JPEGImageReaderSpi()));
> ImageIO.getImageReader(new JPEGImageWriter(new JPEGImageWriterSpi()));
> ImageIO.getImageWriter(new PNGImageReader(new PNGImageReaderSpi()));
> Results:
> org.apache.harmony.x.imageio.plugins.jpeg.JPEGImageWriter@4c4feb1
> org.apache.harmony.x.imageio.plugins.jpeg.JPEGImageReader@4c50594
> org.apache.harmony.x.imageio.plugins.png.PNGImageWriter@4c50e6e
> These are the SUN's result:
> com.sun.imageio.plugins.jpeg.JPEGImageWriter@b1c260
> com.sun.imageio.plugins.jpeg.JPEGImageReader@100ab23
> com.sun.imageio.plugins.png.PNGImageWriter@1bd0dd4

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message