harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Hindess (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5940) Fixes problems in TextUtils
Date Wed, 24 Feb 2010 22:49:28 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838050#action_12838050
] 

Mark Hindess commented on HARMONY-5940:
---------------------------------------

This patch looks reasonable but commenting out the if is certainly the wrong thing to do.
 Either remove the if completely or, as I suspect from just reading the patch, fix the if
test to be (abs(pos) > length) since only the (pos < 0) part looks relevant to the second
change in the patch.



> Fixes problems in TextUtils
> ---------------------------
>
>                 Key: HARMONY-5940
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5940
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Tharindu Mathew
>            Assignee: Alexei Zakharov
>         Attachments: TextUtilsFix.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message