harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Regis Xu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6428) [test] Improve the method coverage rate of unit test for java.net
Date Wed, 20 Jan 2010 09:42:07 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802767#action_12802767
] 

Regis Xu commented on HARMONY-6428:
-----------------------------------

I notice in this patch, test_sendLjava_net_DatagramPacketB and test_set_Datagram_SocketImpl_Factory
are removed, are these test case invalidate?

The new added test case test_set_Datagram_SocketImpl_Factory has following comments:

+    /**
+     * this testcase should be called at last, for after factory set, the method
+     * createDatagramSocketImpl() will called every time a new DatagramSocket
+     * created. that is to say, this test case will affect other testcases.
+     */

I don't think this good way to write test case depends on the execution of test case. Can
setting the factory to null change factory to default one?


> [test] Improve the method coverage rate of unit test for java.net
> -----------------------------------------------------------------
>
>                 Key: HARMONY-6428
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6428
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Jim Yu
>         Attachments: HARMONY-6428.diff
>
>
> The baseline of the method coverage rate for java.net is 92%  (582/634) . This patch
will add some testcases to improve the method coverage rate to 94%  (595/634) .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message