harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ray Chen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-6407) [java6][classlib]NetworkInterface constructor different from trunk, will throw NPE if network interface has no address
Date Mon, 21 Dec 2009 01:37:18 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ray Chen updated HARMONY-6407:
------------------------------

    Attachment: Harmony6407.diff

Since the addresses are stored in a LinkedList in java6 branch while they are stored in an
array in trunk.

So I don't think merge is a good idea.

In the patch, I just add a if(address != null) statement,   and seems it works well. Most
of the NPE of luni module are resolved.

Would some committer please review this? 

> [java6][classlib]NetworkInterface constructor different from trunk, will throw NPE if
network interface has no address
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6407
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6407
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 6.0M1
>            Reporter: Ray Chen
>         Attachments: Harmony6407.diff
>
>
> NetworkInterface of java6 branch is different from NetworkInterface of trunk.
> In their constructors, trunk simply assign the addresses to the "addresses" field, but
in java6 branch it assign addresses one by one which ignore the situation that passed in addresses
may be null.
> Merge trunk to java6, or add a if(addresses != null) will solve the NPE error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message