harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Wilson (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-6396) Several null handling bugs in collections
Date Tue, 01 Dec 2009 19:41:20 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Jesse Wilson updated HARMONY-6396:

    Attachment: Fixes_for_nullness_bugs_in_java_util_2.patch	

I've revised the patch to include fixes for these additional problems:
 - Fixing equals and identity equality problems for reverse comparators
 - Fixing Collections.min() and Collections.max() to work with a null comparator
 - Changing checked collections to permit null. This behaviour is also broken in RI 1.5 and
1.6. The patch makes us consistent with OpenJDK 1.6.
 - Changing checked collections to make addAll() fail atomically.

> Several null handling bugs in collections
> -----------------------------------------
>                 Key: HARMONY-6396
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6396
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: SVN Revision: 882389
>            Reporter: Jesse Wilson
>            Assignee: Jesse Wilson
>         Attachments: Fixes_for_nullness_bugs_in_java_util.patch, Fixes_for_nullness_bugs_in_java_util_2.patch

> I've attached a patch for various correctness issues in our collections:
>  - Maps with null values used to think they were equal to every other map with the same
>  - Map.equals() and Set.equals() didn't recover from NPEs in contains().
>  - singletonMap()'s entry didn't implement toString().
>  - TreeMaps with natural ordering permitted a null element, if it was the first element
ever added.
>  - TreeSets didn't return the right status messages on add() and remove() when nulls
were in play.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message