Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 22567 invoked from network); 4 Nov 2009 12:49:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 Nov 2009 12:49:54 -0000 Received: (qmail 46859 invoked by uid 500); 4 Nov 2009 12:49:54 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 46793 invoked by uid 500); 4 Nov 2009 12:49:54 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 46784 invoked by uid 99); 4 Nov 2009 12:49:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Nov 2009 12:49:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Nov 2009 12:49:51 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id B8E96238897A; Wed, 4 Nov 2009 12:49:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r832728 - /harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/MessageDigest.java Date: Wed, 04 Nov 2009 12:49:30 -0000 To: commits@harmony.apache.org From: tellison@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091104124930.B8E96238897A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: tellison Date: Wed Nov 4 12:49:30 2009 New Revision: 832728 URL: http://svn.apache.org/viewvc?rev=832728&view=rev Log: Clarify comment on ensuring constant time equality checking. Modified: harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/MessageDigest.java Modified: harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/MessageDigest.java URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/MessageDigest.java?rev=832728&r1=832727&r2=832728&view=diff ============================================================================== --- harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/MessageDigest.java (original) +++ harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/MessageDigest.java Wed Nov 4 12:49:30 2009 @@ -296,8 +296,8 @@ if (digesta.length != digestb.length) { return false; } - // No early return is allowed to avoid timing attack - // We have to return false until all elements are compared + // No early return is allowed to avoid timing attack. + // We must not return false until all elements are compared // to keep the computing time constant boolean result = true; for (int i = 0; i < digesta.length; i++) {