harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Deakin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6392) [classlib][swing] Test failures in javax.swing.text.html.HTMLDocument_Reader_ActionsTest
Date Thu, 26 Nov 2009 17:00:39 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782938#action_12782938
] 

Oliver Deakin commented on HARMONY-6392:
----------------------------------------

I've narrowed the failing classes down to ZipFile and ZipEntry. Replacing these two classes
with the M11 versions makes the tests above pass.

It looks like we're reading javax\swing\text\html\parser\html32.bdtd (which is where the ZipFile/ZipEntry
classes come in). I see that with the M12 version of those classes we end up throwing an ASN1Exception
at line 886 of BerInputStream.java (right at the start of it's read() method). This unravels
the stack up to ParserDelegator.createDTD() which has a "try ... catch(Exception e) { // do
nothing }" around the DTD read. The exception is ignored and we carry on, but the DTD has
not been fully populated and it looks like this is the cause of the html not being processed
correctly and the tests failing. Needless to say, this exception is not thrown with the M11
version of ZipFile/ZipEntry and the DTD is read correctly.

The question now is why offset==buffer.length at the start of the BerInputStream.read() call
with the new ZipFile/ZipEntry classes.

> [classlib][swing] Test failures in javax.swing.text.html.HTMLDocument_Reader_ActionsTest
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6392
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6392
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M12
>         Environment: Windows x86
>            Reporter: Oliver Deakin
>
> I see 1 failure and 1 error.
> javax.swing.text.html.HTMLDocument_Reader_ActionsTest.testHarmony_4582 fails with output:
> N/A
> java.lang.NullPointerException
> at javax.swing.text.html.HTMLDocument_Reader_ActionsTest.testHarmony_4582(HTMLDocument_Reader_ActionsTest.java:584)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:116)
> at javax.swing.BasicSwingTestCase.runBareImpl(BasicSwingTestCase.java:121)
> at javax.swing.BasicSwingTestCase$1.run(BasicSwingTestCase.java:135)
> at java.lang.Thread.run(Thread.java:669)
> javax.swing.text.html.HTMLDocument_Reader_ActionsTest.testHarmony_4615 fails with output:
> null expected:<[line4 line4]> but was:<[ line4 line]>
> junit.framework.ComparisonFailure: null expected:<[line4 line4]> but was:<[line4
line]>
> at javax.swing.text.html.HTMLDocument_Reader_ActionsTest.testHarmony_4615(HTMLDocument_Reader_ActionsTest.java:601)
> at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:116)
> at javax.swing.BasicSwingTestCase.runBareImpl(BasicSwingTestCase.java:121)
> at javax.swing.BasicSwingTestCase$1.run(BasicSwingTestCase.java:135)
> at java.lang.Thread.run(Thread.java:669)
> These tests pass for me against M11.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message