harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ray Chen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6368) [java6][classlib][luni]PropertiesTest of java6 branch failed
Date Mon, 02 Nov 2009 08:04:59 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772451#action_12772451
] 

Ray Chen commented on HARMONY-6368:
-----------------------------------

Hi Regis,

First, the java doc removed is because the load(InputStream in) invoke
load(Reader reader) now, so the logic is moved to the load(Reader reader).
Maybe we should add the doc before the load(Reader reader)?

Second, the isAscill() method used "newline" to distinguish between ascii
and ebcdic, so I think the method name is OK. However I do agree with you we
should add some comments to describe it.

Any other comments?




-- 
Regards,

Ray Chen


> [java6][classlib][luni]PropertiesTest of java6 branch failed
> ------------------------------------------------------------
>
>                 Key: HARMONY-6368
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6368
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: All platform
>            Reporter: Ray Chen
>         Attachments: 6368.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> PropertiesTest failed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message