harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Regis Xu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6369) [java6][classlib][luni]Get network interface information failed on AIX, netif.c does NOT use portlib code as trunk
Date Mon, 09 Nov 2009 09:22:32 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774909#action_12774909
] 

Regis Xu commented on HARMONY-6369:
-----------------------------------

sound reasonable. There is no difference in spec between java5 and java6, so I suppose the
code should be the same after fixing the issue. After applied Harmony-6369.diff, the most
of logic is the same,  except code format is different and some check is ignored, for example:
    hysock_get_network_interfaces(&networkInterfaceArray,preferIPv4Stack(env));
the return value should be checked.

> [java6][classlib][luni]Get network interface information failed on AIX, netif.c does
NOT use portlib code as trunk
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6369
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6369
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX
>            Reporter: Ray Chen
>         Attachments: Harmony-6369.diff
>
>
> Hi All,
> On AIX, failed to get the network interface information (name, IP, mac and so on) correctly.
> The java code actually invoke the native code in netif.c.
> I notice that in harmony truck, in netif.c Java_java_net_NetworkInterface_getNetworkInterfacesImpl()
simply invoke the portlib API hysock_get_network_interfaces() to get network interface infomation.
> But in java6 branch according to JIRA 4155, netif.c was modified and added some API for
java6.
> The question is why in java6 branch,  netif.c has its own implementation to get the network
interface information instead of invoking the portlib code?
> I think it should invoke the portlib to make the similar code in only one place.
> Any comments?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message