Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 25666 invoked from network); 11 Oct 2009 03:50:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 11 Oct 2009 03:50:04 -0000 Received: (qmail 87037 invoked by uid 500); 11 Oct 2009 03:50:03 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 86975 invoked by uid 500); 11 Oct 2009 03:50:03 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 86966 invoked by uid 99); 11 Oct 2009 03:50:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Oct 2009 03:50:03 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Oct 2009 03:49:54 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 3988223888DA; Sun, 11 Oct 2009 03:49:03 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r824010 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/Inet4Address.java Date: Sun, 11 Oct 2009 03:49:03 -0000 To: commits@harmony.apache.org From: ndbeyer@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091011034903.3988223888DA@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: ndbeyer Date: Sun Oct 11 03:49:02 2009 New Revision: 824010 URL: http://svn.apache.org/viewvc?rev=824010&view=rev Log: convert string concatenation in loop to use StringBuilder Modified: harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/Inet4Address.java Modified: harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/Inet4Address.java URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/Inet4Address.java?rev=824010&r1=824009&r2=824010&view=diff ============================================================================== --- harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/Inet4Address.java (original) +++ harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/Inet4Address.java Sun Oct 11 03:49:02 2009 @@ -218,14 +218,14 @@ */ @Override public String getHostAddress() { - String hostAddress = ""; //$NON-NLS-1$ + final StringBuilder hostAddress = new StringBuilder(); for (int i = 0; i < 4; i++) { - hostAddress += ipaddress[i] & 255; + hostAddress.append(ipaddress[i] & 255); if (i != 3) { - hostAddress += "."; //$NON-NLS-1$ + hostAddress.append('.'); } } - return hostAddress; + return hostAddress.toString(); } /**