Return-Path: 
 <commits-return-60688-apmail-harmony-commits-archive=harmony.apache.org@harmony.apache.org>
Delivered-To: apmail-harmony-commits-archive@www.apache.org
Received: (qmail 92244 invoked from network); 16 Oct 2009 12:59:54 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 16 Oct 2009 12:59:54 -0000
Received: (qmail 27068 invoked by uid 500); 16 Oct 2009 12:59:54 -0000
Delivered-To: apmail-harmony-commits-archive@harmony.apache.org
Received: (qmail 27001 invoked by uid 500); 16 Oct 2009 12:59:54 -0000
Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@harmony.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@harmony.apache.org>
List-Post: <mailto:commits@harmony.apache.org>
List-Id: <commits.harmony.apache.org>
Reply-To: dev@harmony.apache.org
Delivered-To: mailing list commits@harmony.apache.org
Received: (qmail 26990 invoked by uid 99); 16 Oct 2009 12:59:54 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Oct 2009 12:59:54 +0000
X-ASF-Spam-Status: No, hits=-10.5 required=5.0
	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Oct 2009 12:59:52 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 48E82234C045
	for <commits@harmony.apache.org>; Fri, 16 Oct 2009 05:59:31 -0700 (PDT)
Message-ID: <1624557306.1255697971284.JavaMail.jira@brutus>
Date: Fri, 16 Oct 2009 05:59:31 -0700 (PDT)
From: "Hudson (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-6356) [classlib][lang-managment]
 Improvements to lang-management classes from findbugs
In-Reply-To: <1405301877.1255614991290.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HARMONY-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766520#action_12766520 ] 

Hudson commented on HARMONY-6356:
---------------------------------

Integrated in Harmony-1.5-head-linux-x86_64 #505 (See [http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/505/])
    Commit patch for  ([classlib][lang-managment] Improvements to lang-management classes from findbugs)


> [classlib][lang-managment] Improvements to lang-management classes from findbugs
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-6356
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6356
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: all
>            Reporter: Catherine Hope
>            Assignee: Oliver Deakin
>            Priority: Minor
>             Fix For: 5.0M12
>
>         Attachments: lang-managment.patch
>
>
> Improvements to lang-management classes from running findbugs, and exclusions list.
> Most changes are performance suggestions, e.g. Boolean.valueOf and removing new String(<existing String>), and some redundant logic, e.g. String fileNameValue = (fileName == null) ? null : new String(fileName) 
> The exclude is for returning a mutable object from java.lang.management.ThreadInfo.getStackTrace(), but I checked the RI and it does the same, so I didn't make any changes:
>         StackTraceElement[] stack1 = ti.getStackTrace();
>         String dummyData = "dummy";
>         StackTraceElement dummyElement =  new StackTraceElement(dummyData, dummyData, dummyData, 0);
>         stack1[0] = dummyElement;
>         StackTraceElement[] stack2 = ti.getStackTrace();
>         assertNotSame(stack1[0], stack2[0]);  // this fails on Sun and Harmony

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.