harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From telli...@apache.org
Subject svn commit: r824779 - /harmony/enhanced/classlib/trunk/modules/print/src/main/java/common/org/apache/harmony/x/print/ServiceUIDialog.java
Date Tue, 13 Oct 2009 14:25:25 GMT
Author: tellison
Date: Tue Oct 13 14:25:24 2009
New Revision: 824779

URL: http://svn.apache.org/viewvc?rev=824779&view=rev
Log:
Mark type constants as final to avoid people changing them on us.

Modified:
    harmony/enhanced/classlib/trunk/modules/print/src/main/java/common/org/apache/harmony/x/print/ServiceUIDialog.java

Modified: harmony/enhanced/classlib/trunk/modules/print/src/main/java/common/org/apache/harmony/x/print/ServiceUIDialog.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/print/src/main/java/common/org/apache/harmony/x/print/ServiceUIDialog.java?rev=824779&r1=824778&r2=824779&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/print/src/main/java/common/org/apache/harmony/x/print/ServiceUIDialog.java
(original)
+++ harmony/enhanced/classlib/trunk/modules/print/src/main/java/common/org/apache/harmony/x/print/ServiceUIDialog.java
Tue Oct 13 14:25:24 2009
@@ -165,19 +165,19 @@
 public class ServiceUIDialog extends ServiceUIDialogTemplate {
 
     // State of dialog:
-    public static int APPROVE_PRINT = 1;    // OK button was pressed
-    public static int CANSEL_PRINT = -1;    // Cancel button was pressed
-    public static int SETUP_ERROR = 2;      // Dialog Setup was finished with 
-                                            // error, dialog can not be shown
-    public static int SETUP_OK = 3;         // Dialog setup was OK, 
-                                            // you can show the dialog
-    int dialogResult = 0;                   // Current dialog status
+    public static final int APPROVE_PRINT = 1;    // OK button was pressed
+    public static final int CANSEL_PRINT = -1;    // Cancel button was pressed
+    public static final int SETUP_ERROR = 2;      // Dialog Setup was finished with 
+                                                  // error, dialog can not be shown
+    public static final int SETUP_OK = 3;         // Dialog setup was OK, 
+                                                  // you can show the dialog
+    int dialogResult = 0;                         // Current dialog status
     
     // Dialog type:
-    public static int PRINT_DIALOG = 1;     // Dialog for PrintService selecting,
-                                            // all dialog tabs are visible 
-    public static int PAGE_DIALOG = 2;      // Page setup dialog:
-                                            // only PageSetup dialog tab is visible
+    public static final int PRINT_DIALOG = 1;     // Dialog for PrintService selecting,
+                                                  // all dialog tabs are visible 
+    public static final int PAGE_DIALOG = 2;      // Page setup dialog:
+                                                  // only PageSetup dialog tab is visible
     private int dialogType = PRINT_DIALOG;  // dialog type
     
     PrintService [] services = null;        // Print services array for the choice



Mime
View raw message