harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From telli...@apache.org
Subject svn commit: r821752 - /harmony/enhanced/classlib/trunk/modules/sql/make/findbugs-exclude-filter.xml
Date Mon, 05 Oct 2009 10:54:52 GMT
Author: tellison
Date: Mon Oct  5 10:54:52 2009
New Revision: 821752

URL: http://svn.apache.org/viewvc?rev=821752&view=rev
Log:
Exclude more false positive FindBugs warnings for SQL.

Modified:
    harmony/enhanced/classlib/trunk/modules/sql/make/findbugs-exclude-filter.xml

Modified: harmony/enhanced/classlib/trunk/modules/sql/make/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/sql/make/findbugs-exclude-filter.xml?rev=821752&r1=821751&r2=821752&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/sql/make/findbugs-exclude-filter.xml (original)
+++ harmony/enhanced/classlib/trunk/modules/sql/make/findbugs-exclude-filter.xml Mon Oct 
5 10:54:52 2009
@@ -30,4 +30,22 @@
 		<Bug pattern="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS" />
 	</Match>
 
+	<!-- Spec shows there is no compareTo(Object) method. -->
+	<Match>
+		<Class name="java.sql.Timestamp" />
+		<Bug pattern="CO_SELF_NO_OBJECT" />
+	</Match>
+
+	<!-- Spec shows there is an equals() but no hashCode(). Shameful.-->
+	<Match>
+		<Class name="java.sql.Timestamp" />
+		<Bug pattern="HE_EQUALS_NO_HASHCODE" />
+	</Match>
+
+	<!-- equals() follows spec and is not symmetrical.-->
+	<Match>
+		<Class name="java.sql.Timestamp" />
+		<Bug pattern="EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC" />
+	</Match>
+
 </FindBugsFilter>



Mime
View raw message