harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From telli...@apache.org
Subject svn commit: r820799 - /harmony/enhanced/classlib/trunk/modules/archive/make/findbugs-exclude-filter.xml
Date Thu, 01 Oct 2009 21:22:16 GMT
Author: tellison
Date: Thu Oct  1 21:22:14 2009
New Revision: 820799

URL: http://svn.apache.org/viewvc?rev=820799&view=rev
Log:
More FindBugs filters copied in from http://svn.apache.org/viewvc/harmony/standard/tools/FindBugs/exclusionFilter.xml

Modified:
    harmony/enhanced/classlib/trunk/modules/archive/make/findbugs-exclude-filter.xml

Modified: harmony/enhanced/classlib/trunk/modules/archive/make/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/archive/make/findbugs-exclude-filter.xml?rev=820799&r1=820798&r2=820799&view=diff
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/archive/make/findbugs-exclude-filter.xml (original)
+++ harmony/enhanced/classlib/trunk/modules/archive/make/findbugs-exclude-filter.xml Thu Oct
 1 21:22:14 2009
@@ -34,5 +34,40 @@
 		<Bug pattern="CN_IDIOM_NO_SUPER_CALL" />
 	</Match>
 
+	<!-- Exception is ignored on purpose -->
+	<Match>
+		<Class name="java.util.jar.JarVerifier" />
+		<Method name="verifyCertificate" />
+		<Bug code="DE" />
+	</Match>
+
+	<!-- OK to ignore return value as result is checked in next line -->
+	<Match>
+		<Class name="java.util.zip.ZipInputStream" />
+		<Method name="closeEntry" />
+		<Bug code="RR" />
+	</Match>
+
+	<!-- OK to return actual byte array as this matches RI's behaviour -->
+	<Match>
+		<Class name="java.util.zip.ZipEntry" />
+		<Method name="getExtra" />
+		<Bug code="EI" />
+	</Match>
+
+	<!-- OK to use actual byte array as this matches RI's behaviour -->
+	<Match>
+		<Class name="java.util.zip.ZipEntry" />
+		<Method name="setExtra" />
+		<Bug code="EI2" />
+	</Match>
+
+	<!-- OK to use actual byte array as this matches RI's behaviour -->
+	<Match>
+		<Class name="java.util.zip.Deflater" />
+		<Method name="setInput" />
+		<Bug code="EI2" />
+	</Match>
+
 </FindBugsFilter>
 



Mime
View raw message