harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6344) Provide a lock-free version of ReferenceQueue
Date Mon, 12 Oct 2009 15:21:31 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764712#action_12764712
] 

Tim Ellison commented on HARMONY-6344:
--------------------------------------

Thanks for the updated attachment James.

A few comments:

Non-critical:

 - Please provide updates to existing Harmony code as patches, it makes it clearer what you
are changing when we are reviewing the code.  For now, I can diff the new implementations
of Reference and ReferenceQueue.

 - Also, best not to include unnecessary files, such as the .class files and helper .sh files.

More important:

 - You say that the code was written by yourself and others.  We will need contribution questionnaires
from ALL authors to ensure the code is suitable for inclusion in Harmony.  We also need some
indication that the authors are willing to have their work contributed to the project (their
own say so is best).

 - We need you to remove the IBM copyright statements fom the source code, and add the Apache
header to the test case.


A more generic question.  Does it make sense for Harmony to maintain a copy of the Amino queues?
 it may make more sense to have Harmony download the Amino class library as a dependency,
otherwise we will potentially diverge on implementation changes.

Regards,
Tim

> Provide a lock-free version of ReferenceQueue
> ---------------------------------------------
>
>                 Key: HARMONY-6344
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6344
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: Any modern multi-core environment
>            Reporter: James Gan
>            Assignee: Tim Ellison
>         Attachments: amino_rfq.zip
>
>
> In Harmony, the original ReferenceQueue is a lock-base queue, which doesn't scale well
on multi-core environment. Here I attached an lock-free version of ReferenceQueue based on
Amino Library, which has better scalability than original queue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message