harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Catherine Hope (JIRA)" <j...@apache.org>
Subject [jira] Created: (HARMONY-6356) [classlib][lang-managment] Improvements to lang-management classes from findbugs
Date Thu, 15 Oct 2009 13:56:31 GMT
[classlib][lang-managment] Improvements to lang-management classes from findbugs
--------------------------------------------------------------------------------

                 Key: HARMONY-6356
                 URL: https://issues.apache.org/jira/browse/HARMONY-6356
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
         Environment: all
            Reporter: Catherine Hope
            Priority: Minor
         Attachments: lang-managment.patch

Improvements to lang-management classes from running findbugs, and exclusions list.

Most changes are performance suggestions, e.g. Boolean.valueOf and removing new String(<existing
String>), and some redundant logic, e.g. String fileNameValue = (fileName == null) ? null
: new String(fileName) 

The exclude is for returning a mutable object from java.lang.management.ThreadInfo.getStackTrace(),
but I checked the RI and it does the same, so I didn't make any changes:
        StackTraceElement[] stack1 = ti.getStackTrace();
        String dummyData = "dummy";
        StackTraceElement dummyElement =  new StackTraceElement(dummyData, dummyData, dummyData,
0);
        stack1[0] = dummyElement;
        StackTraceElement[] stack2 = ti.getStackTrace();
        assertNotSame(stack1[0], stack2[0]);  // this fails on Sun and Harmony


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message