harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-6343) [classlib][nio]SocketChannel.connect() can return true in non-blocking mode
Date Tue, 29 Sep 2009 13:32:16 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tim Ellison resolved HARMONY-6343.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M12

Thanks Ray.

A slightly modified version of your patch was applied at repo revision r819939.  I maintained
the logic but refactored the code to be a bit more readable.

Please verify the patch.


> [classlib][nio]SocketChannel.connect() can return true in non-blocking mode
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-6343
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6343
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: AIX
>            Reporter: Ray Chen
>            Assignee: Tim Ellison
>             Fix For: 5.0M12
>
>         Attachments: patch_6343.diff
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Many test cases of SocketChannelTest failed on AIX: the connect() function always return
true when connect to server address (localhost) in non-blocking mode.
> However, the specification says "If this channel is in non-blocking mode then an invocation
of this method initiates a non-blocking connection operation. If the connection is established
immediately, as can happen with a local connection, then this method returns true. Otherwise
this method returns false and the connection operation must later be completed by invoking
the finishConnect method."
> But SocketChannelTest supposes that everytime connect() return false in non-blocking
mode. 
> There are bugs in SocketChannelTest. 
> And SocketChannelImp also need a fix to change to right status if connect successful
immediately.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message