harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6341) [classlib][luni] - implement File.isAbsolute/getAbsolutePath() in java code
Date Fri, 25 Sep 2009 10:10:16 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759471#action_12759471

Tim Ellison commented on HARMONY-6341:

Regis, can you help me understand the value of patch 002?

The code seems to be (almost) a copy of the existing code in properPath(boolean), however,
it does not set the local variable to cache the absolute path so arguably it is not as helpful?

> [classlib][luni] - implement File.isAbsolute/getAbsolutePath() in java code
> ---------------------------------------------------------------------------
>                 Key: HARMONY-6341
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6341
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>    Affects Versions: 5.0M11
>            Reporter: Regis Xu
>            Assignee: Tim Ellison
>         Attachments: 0001-re-implement-File.isAbsolute-in-java-code.patch, 0002-re-implement-File.getAbsolutePath-in-java-code.patch,
> File.isAboslute/getAboslutePath() never invoke system call, so it's not necessary to
do it via expensive JNI call.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message