harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Regis Xu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6341) [classlib][luni] - implement File.isAbsolute/getAbsolutePath() in java code
Date Mon, 28 Sep 2009 04:47:16 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760147#action_12760147
] 

Regis Xu commented on HARMONY-6341:
-----------------------------------

Tim, thanks for helping review the patches.

patch 002 aims to avoid decoding bytes to UTF8 chars (the title should be fixed). Because
in the most of cases, absolute path of file is simply $user.dir + path, while old implementation
need to get "properPath" which is byte array and then convert to String, even "properPath"
has been cached, the converting step is still slower than string concat.

The code original from "properPath(boolean)" and fix some minor issues to pass the new added
test cases. And we can change "properPath(boolean)" to call getAbsolutePath to avoid the duplicate
code (I can prepare patch for this).

> [classlib][luni] - implement File.isAbsolute/getAbsolutePath() in java code
> ---------------------------------------------------------------------------
>
>                 Key: HARMONY-6341
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6341
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>    Affects Versions: 5.0M11
>            Reporter: Regis Xu
>            Assignee: Tim Ellison
>         Attachments: 0001-re-implement-File.isAbsolute-in-java-code.patch, 0002-re-implement-File.getAbsolutePath-in-java-code.patch,
0003-remove-unsed-native-methods-properPathImpl-and-getPl.patch
>
>
> File.isAboslute/getAboslutePath() never invoke system call, so it's not necessary to
do it via expensive JNI call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message