harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (HARMONY-6323) [classlib] [luni] Simplify and speed-up collection shuffle, add a non-probabilistic test
Date Thu, 03 Sep 2009 13:22:57 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tim Ellison reopened HARMONY-6323:
----------------------------------


Temporarily re-opening this issue as I have reverted the test case update in r810919.

While the new tests pass ok on DRLVM, they have failed on IBM J9 VME with 

testShuffleRandomAccessWithSeededRandom	Failure	expected:<[B, A, D, C, G, E, F]> but
was:<[A, B, D, C, G, E, F]>
testShuffleWithSeededRandom	Failure	expected:<[B, A, D, C, G, E, F]> but was:<[A,
B, D, C, G, E, F]>

The immediate thought was that the Random seed was returning different random values, but
a quick check shows that is not so.  I'll investigate further.


> [classlib] [luni] Simplify and speed-up collection shuffle, add a non-probabilistic test
> ----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6323
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6323
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: SVN Revision 801399
>            Reporter: Jesse Wilson
>            Assignee: Tim Ellison
>            Priority: Minor
>             Fix For: 5.0M12
>
>         Attachments: Shuffle-fixes.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Shuffle needlessly tests Random.nextInt() for a negative value
> It iterates from index N-1 to 0, which means it always swaps index 0 with itself needlessly.
> It is only tested with probabilistic tests, the patch adds a proper test. Note that the
attached test also passes on the RI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message