harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Wilson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6323) [classlib] [luni] Simplify and speed-up collection shuffle, add a non-probabilistic test
Date Fri, 04 Sep 2009 16:19:58 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751517#action_12751517

Jesse Wilson commented on HARMONY-6323:

Yup, your fixes look good, and I'm disappointed I made such a clumsy off-by-one error! Thanks!

I'm surprised that the test behaves differently on different VMs; with the random properly
seeded it should give the same output everywhere. I'm going to look into this.

> [classlib] [luni] Simplify and speed-up collection shuffle, add a non-probabilistic test
> ----------------------------------------------------------------------------------------
>                 Key: HARMONY-6323
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6323
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: SVN Revision 801399
>            Reporter: Jesse Wilson
>            Assignee: Tim Ellison
>            Priority: Minor
>             Fix For: 5.0M12
>         Attachments: Shuffle-fixes.patch
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
> Shuffle needlessly tests Random.nextInt() for a negative value
> It iterates from index N-1 to 0, which means it always swaps index 0 with itself needlessly.
> It is only tested with probabilistic tests, the patch adds a proper test. Note that the
attached test also passes on the RI.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message