harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6279) [classlib][luni] file.encoding is always set to ISO-9959-1 if using drlvm
Date Thu, 30 Jul 2009 10:47:14 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737065#action_12737065
] 

Alexey Varlamov commented on HARMONY-6279:
------------------------------------------

Looks better now. Few issues remained:
1) such code does not work the way you might have intended:
locale = "8859_1";
It should be like:
strcpy(locale, "8859_1");
2) strcpy would be more elegant than memcpy
3) For consistency, windows function could also check buffer size - didn't you get "unused"
warning btw?
4) No sense to free(propVal); as it is null anyway

> [classlib][luni] file.encoding is always set to ISO-9959-1 if using drlvm
> -------------------------------------------------------------------------
>
>                 Key: HARMONY-6279
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6279
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Li Jing Qin
>         Attachments: HARMONY-6279.diff, HARMONY-6279.v2.diff, HARMONY-6279.v3.diff
>
>
> Our file.encoding in the system property is always set 8859-1 if we using drlvm.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message