harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6256) [classlib][awt] Incorrect test of transformation type when clipping
Date Mon, 13 Jul 2009 10:11:14 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730276#action_12730276
] 

Tim Ellison commented on HARMONY-6256:
--------------------------------------

Thank you for your contribution Ladislav!

Please could you complete the Apache Harmony questionnaire about your prior exposure in this
area of code, to ensure that we can continue to use your contributions unencumbered.  The
questionnaire is here:
  http://harmony.apache.org/auth_cont_quest.html

Please send a scanned copy of the completed questionnaire to "private (at) harmony. apache.
org" mail address

> [classlib][awt] Incorrect test of transformation type when clipping
> -------------------------------------------------------------------
>
>                 Key: HARMONY-6256
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6256
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M10
>            Reporter: Ladislav Jahoda
>            Assignee: Tim Ellison
>             Fix For: 5.0M11
>
>         Attachments: CommonGraphics2D.java.patch
>
>
> In CommonGraphics2D both clip and setClip use bitwise AND operator for transformation
type test. This is wrong. Note that tested TYPE_IDENTITY is defined as zero, so bitwise AND
always gives zero and identity transformation is not recognized. This means that even the
most simple cases with identity transformation are rasterized. Moreover, the test logic doesn't
make sense for TYPE_TRANSLATION either - note that if the object is just rotated then it is
rasterized, but when it is translated and rotated then because of TYPE_TRANSLATION bit set
it is only translated. I think the bitwise AND is incorrect here and test should use == instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message