harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-6267) [classlib][text] Implementation of AttributedCharacterIterator.Attribute.equals should only return true if objects are the same
Date Mon, 13 Jul 2009 11:41:14 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tim Ellison resolved HARMONY-6267.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M11

Thanks Catherine.

I applied a modified version of your patch to the TEXT module at repo revision r793553.

Since the definition of equals() was changed we also have to change the definition of hashCode()
to match.  It now simply delegates to the Object.hashCode() but is marked as final.

That change also required fixing bogus tests for java.text.FieldPosition#hashCode() which
makes assumptions about the hashCode implementation that are unwarranted by the spec.

Please check this now resolves your issue.


> [classlib][text] Implementation of AttributedCharacterIterator.Attribute.equals should
only return true if objects are the same
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6267
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6267
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: all
>            Reporter: Catherine Hope
>            Assignee: Tim Ellison
>            Priority: Minor
>             Fix For: 5.0M11
>
>         Attachments: patch.txt
>
>
> According to the spec for class AttributedCharacterIterator.Attribute, the equals method:
> "Compares two objects for equality. This version only returns true for x.equals(y) if
x and y refer to the same object, and guarantees this for all subclasses."
> At the moment the method returns true if the objects were constructed with the same name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message