harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Catherine Hope (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-6267) Implementation of AttributedCharacterIterator.Attribute.equals should only return true if objects are the same
Date Fri, 10 Jul 2009 17:11:15 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Catherine Hope updated HARMONY-6267:
------------------------------------

    Attachment: patch.txt

Attached patch contains a fix to java.text.AttributedCharacterIterator.Attribute to just perform
a "==" in the equals() method.

The fix breaks the readResolve() methods of both that class and the java.text.DateFormat.Field
subclass.  Patch also contains fix for these methods, which basically inlines the logic from
the old equals method.  Also includes a new testcase "org.apache.harmony.text.tests.java.text.AttributedCharacterIteratorAttributeTest"
that demonstrates the original problem and performs some additional tests on the other methods
from that inner class, similarly to "DataFormatFieldTest" (there's a spelling mistake in that
class name).

> Implementation of AttributedCharacterIterator.Attribute.equals should only return true
if objects are the same
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6267
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6267
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: all
>            Reporter: Catherine Hope
>            Priority: Minor
>         Attachments: patch.txt
>
>
> According to the spec for class AttributedCharacterIterator.Attribute, the equals method:
> "Compares two objects for equality. This version only returns true for x.equals(y) if
x and y refer to the same object, and guarantees this for all subclasses."
> At the moment the method returns true if the objects were constructed with the same name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message