harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Jing Qin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6279) [classlib][luni] file.encoding is always set to ISO-9959-1 if using drlvm
Date Wed, 22 Jul 2009 06:02:14 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733996#action_12733996
] 

Li Jing Qin commented on HARMONY-6279:
--------------------------------------

Thanks Alexey !
1. Sure. I will change it.
2. I would like to refactor the code. Move the memory allocation to the
luniglob, let the luniglob to care about the memory. Since it is the
luniglob where to free the memory. What do you think about this?
3. Sure. I will change it.
4. strdup? Would you please give some details?
5. I have done this at first. But I feel it will be too many lines in that
file, I merge 3 or 4 in one line.
6. Sure. There seems we have the agreement that file.encoding can not be
null if we use System.getProperty("file.encoding"). Maybe we can remove the
null check code in java.




-- 
Yours sincerely,
Charles Lee


> [classlib][luni] file.encoding is always set to ISO-9959-1 if using drlvm
> -------------------------------------------------------------------------
>
>                 Key: HARMONY-6279
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6279
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Li Jing Qin
>         Attachments: HARMONY-6279.diff, HARMONY-6279.v2.diff
>
>
> Our file.encoding in the system property is always set 8859-1 if we using drlvm.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message