harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-6256) [classlib][awt] Incorrect test of transformation type when clipping
Date Mon, 13 Jul 2009 10:53:14 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tim Ellison resolved HARMONY-6256.
----------------------------------

    Resolution: Fixed

Thanks Ladislav.

Patch applied to AWT module at repo revision r793537.

Please check it was applied as you expected.

Can you think of a test that shows this is the right thing to do so we can add it to our regression
test suite?

> [classlib][awt] Incorrect test of transformation type when clipping
> -------------------------------------------------------------------
>
>                 Key: HARMONY-6256
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6256
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M10
>            Reporter: Ladislav Jahoda
>            Assignee: Tim Ellison
>             Fix For: 5.0M11
>
>         Attachments: CommonGraphics2D.java.patch
>
>
> In CommonGraphics2D both clip and setClip use bitwise AND operator for transformation
type test. This is wrong. Note that tested TYPE_IDENTITY is defined as zero, so bitwise AND
always gives zero and identity transformation is not recognized. This means that even the
most simple cases with identity transformation are rasterized. Moreover, the test logic doesn't
make sense for TYPE_TRANSLATION either - note that if the object is just rotated then it is
rasterized, but when it is translated and rotated then because of TYPE_TRANSLATION bit set
it is only translated. I think the bitwise AND is incorrect here and test should use == instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message