Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 48781 invoked from network); 26 Jun 2009 13:41:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 26 Jun 2009 13:41:20 -0000 Received: (qmail 92815 invoked by uid 500); 26 Jun 2009 13:41:31 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 92791 invoked by uid 500); 26 Jun 2009 13:41:31 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 92782 invoked by uid 99); 26 Jun 2009 13:41:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jun 2009 13:41:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jun 2009 13:41:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 88147234C055 for ; Fri, 26 Jun 2009 06:41:07 -0700 (PDT) Message-ID: <2140574359.1246023667556.JavaMail.jira@brutus> Date: Fri, 26 Jun 2009 06:41:07 -0700 (PDT) From: "Tim Ellison (JIRA)" To: commits@harmony.apache.org Subject: [jira] Closed: (HARMONY-5741) [drlvm][verifier] thread unsafe and buffer overflow vulnerable code in the verifer In-Reply-To: <1244255739.1208335701972.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-5741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Ellison closed HARMONY-5741. -------------------------------- > [drlvm][verifier] thread unsafe and buffer overflow vulnerable code in the verifer > ---------------------------------------------------------------------------------- > > Key: HARMONY-5741 > URL: https://issues.apache.org/jira/browse/HARMONY-5741 > Project: Harmony > Issue Type: Bug > Components: DRLVM > Reporter: Alexei Fedotov > Assignee: Pavel Pervov > > Negative cases are handled in a following way: > static char err_message[5000]; > [...] > if (result != VF_OK) { > *error = &(err_message[0]); > Method_Handle method = class_get_method(klass, index); > sprintf(*error, "%s/%s%s, pass: %d, instr: %d, reason: %s", class_get_name(klass), method_get_name(method), > method_get_descriptor(method), context.pass, context.processed_instruction, context.error_message); > break; > } > The static buffer then is returned to the caller. Should use a local buffer and replace sprintf with snprintf. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.