Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 80846 invoked from network); 15 Jun 2009 08:20:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Jun 2009 08:20:20 -0000 Received: (qmail 79657 invoked by uid 500); 15 Jun 2009 08:20:31 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 79551 invoked by uid 500); 15 Jun 2009 08:20:31 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 79534 invoked by uid 99); 15 Jun 2009 08:20:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jun 2009 08:20:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jun 2009 08:20:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 80504234C1F2 for ; Mon, 15 Jun 2009 01:20:07 -0700 (PDT) Message-ID: <1251678358.1245054007524.JavaMail.jira@brutus> Date: Mon, 15 Jun 2009 01:20:07 -0700 (PDT) From: "Regis Xu (JIRA)" To: commits@harmony.apache.org Subject: [jira] Resolved: (HARMONY-6095) [classlib][luni] Performance improvement patch for java.text.DateFormatSymbols.DateFormatSymbols(Locale) In-Reply-To: <570393414.1234935181884.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-6095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Regis Xu resolved HARMONY-6095. ------------------------------- Resolution: Fixed Fix Version/s: 5.0M11 Thanks Deven. Patch applied at r784683, please verify it was applied as you expected. > [classlib][luni] Performance improvement patch for java.text.DateFormatSymbols.DateFormatSymbols(Locale) > -------------------------------------------------------------------------------------------------------- > > Key: HARMONY-6095 > URL: https://issues.apache.org/jira/browse/HARMONY-6095 > Project: Harmony > Issue Type: Improvement > Components: Classlib > Affects Versions: 5.0M8 > Reporter: deven you > Assignee: Regis Xu > Fix For: 5.0M11 > > Attachments: DateFormatSymbolsTest.diff, hy-text.diff, hy-text_v2.diff, hy-text_v4.diff > > Original Estimate: 96h > Remaining Estimate: 96h > > this constructor spend much time on getZoneString(), howerver it is rarely used in real world application. so I just delay loading the ZoneStrings > the testcase is : > import java.text.DateFormatSymbols; > import java.util.Locale; > public class TestDateFormatSymbols { > public static void main(String[] args) { > long time = System.currentTimeMillis(); > DateFormatSymbols dfs = new DateFormatSymbols(Locale.getDefault()); > time = System.currentTimeMillis() - time; > > System.out.println("the total time is " + time + " ms!"); > } > } > I have test on on Intel(R) Core(TM)2 Duo Cpu 2.4GHZ, 2.98GB Memory machine, the result is as below: > Harmony patch before: 1125 ms > > Harmony patched: 78 ms -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.