harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Regis Xu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6095) [classlib][luni] Performance improvement patch for java.text.DateFormatSymbols.DateFormatSymbols(Locale)
Date Mon, 15 Jun 2009 06:52:07 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719425#action_12719425
] 

Regis Xu commented on HARMONY-6095:
-----------------------------------

Hi Deven,

I tried to apply patch hy-text_v2.diff but failed:
$ patch -p0 <  /home/bahamut/download/hy-text_v2.diff 
patching file modules/text/src/main/java/java/text/DateFormatSymbols.java
Hunk #2 succeeded at 70 with fuzz 2 (offset 33 lines).
Hunk #3 succeeded at 88 with fuzz 1 (offset 33 lines).
patch: **** malformed patch at line 50: @@ -73,6 +83,9 @@

Would you please take look at this?

> [classlib][luni] Performance improvement patch for java.text.DateFormatSymbols.DateFormatSymbols(Locale)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6095
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6095
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: deven you
>            Assignee: Tony Wu
>         Attachments: DateFormatSymbolsTest.diff, hy-text.diff, hy-text_v2.diff
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> this constructor spend much time on getZoneString(), howerver it is rarely used in real
world application. so I just delay loading the ZoneStrings 
> the testcase is :
> import java.text.DateFormatSymbols;
> import java.util.Locale;
> public class TestDateFormatSymbols {
>     public static void main(String[] args) {
>         long time = System.currentTimeMillis();
>         DateFormatSymbols dfs = new DateFormatSymbols(Locale.getDefault());
>         time = System.currentTimeMillis() - time;
>         
>         System.out.println("the total time is " + time + " ms!");
>     }
> }
> I have test on on Intel(R) Core(TM)2 Duo Cpu 2.4GHZ, 2.98GB Memory machine, the result
is as below:
> Harmony patch before: 1125 ms
> > Harmony patched: 78 ms

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message