Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 86335 invoked from network); 29 Apr 2009 22:57:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 29 Apr 2009 22:57:53 -0000 Received: (qmail 57670 invoked by uid 500); 29 Apr 2009 22:57:53 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 57625 invoked by uid 500); 29 Apr 2009 22:57:53 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 57615 invoked by uid 99); 29 Apr 2009 22:57:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2009 22:57:53 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2009 22:57:51 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6F3A3234C04B for ; Wed, 29 Apr 2009 15:57:30 -0700 (PDT) Message-ID: <1961049256.1241045850453.JavaMail.jira@brutus> Date: Wed, 29 Apr 2009 15:57:30 -0700 (PDT) From: "Nathan Beyer (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-6149) [classlib][lang-management] java.lang.management.MemoryNotificationInfo.from(CompositeData cd) should throw IllegalArgumentException if cd doesn't represent a MemoryNotificationInfo object In-Reply-To: <787689221.1239675855201.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704394#action_12704394 ] Nathan Beyer commented on HARMONY-6149: --------------------------------------- Can you explain the other changes? This seems to add quite a bit of complexity to the code - is it worth it? > [classlib][lang-management] java.lang.management.MemoryNotificationInfo.from(CompositeData cd) should throw IllegalArgumentException if cd doesn't represent a MemoryNotificationInfo object > -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: HARMONY-6149 > URL: https://issues.apache.org/jira/browse/HARMONY-6149 > Project: Harmony > Issue Type: Bug > Components: Classlib > Affects Versions: 5.0M8, 5.0M9 > Reporter: Kevin Zhou > Assignee: Nathan Beyer > Fix For: 5.0M10 > > Attachments: HARMONY-6149.diff, HARMONY6149Test.java > > Original Estimate: 48h > Remaining Estimate: 48h > > For java.lang.management.MemoryNotificationInfo.from(CompositeData cd) method, the Java Spec has specifies that the given CompositeData must contains the following attributes: > ATTRIBUTE_NAME TYPE > poolName java.lang.String > usage javax.management.openmbean.CompositeData > count java.lang.Long > Otherwise, it should throw an java.lang.IllegalArgumentException. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.