Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 10335 invoked from network); 22 Apr 2009 21:33:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 22 Apr 2009 21:33:08 -0000 Received: (qmail 44555 invoked by uid 500); 22 Apr 2009 21:33:08 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 44507 invoked by uid 500); 22 Apr 2009 21:33:08 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 44490 invoked by uid 99); 22 Apr 2009 21:33:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2009 21:33:08 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2009 21:33:07 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 93276234C045 for ; Wed, 22 Apr 2009 14:32:47 -0700 (PDT) Message-ID: <123463824.1240435967601.JavaMail.jira@brutus> Date: Wed, 22 Apr 2009 14:32:47 -0700 (PDT) From: "Tim Ellison (JIRA)" To: commits@harmony.apache.org Subject: [jira] Updated: (HARMONY-6125) [classlib][luni] - remove duplicated security check in File.list In-Reply-To: <1194977504.1237777010456.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Ellison updated HARMONY-6125: --------------------------------- Fix Version/s: 5.0M10 > [classlib][luni] - remove duplicated security check in File.list > ---------------------------------------------------------------- > > Key: HARMONY-6125 > URL: https://issues.apache.org/jira/browse/HARMONY-6125 > Project: Harmony > Issue Type: Sub-task > Components: Classlib > Affects Versions: 5.0M8 > Reporter: Regis Xu > Fix For: 5.0M10 > > Attachments: File.list.refactor.diff > > > in the list implementation: > SecurityManager security = System.getSecurityManager(); > if (security != null) { > security.checkRead(path); > } > if (!isDirectory() || !canRead()) { > return null; > } > isDirectory and canRead also check security by security.checkRead, it's unnecessary and time cost. I'll attach patch to fix this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.