harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6121) [classlib][archive] org.apache.harmony.archive.tests.java.util.jar.ManifestTest fails
Date Wed, 25 Mar 2009 09:10:55 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689037#action_12689037
] 

Tim Ellison commented on HARMONY-6121:
--------------------------------------

Yes, and that fast reflection path is still there in the InputStreamExposer.  I modified it
to throw an UnsupportedOperationException when the reflection 'trick' does not work rather
than trying to read the entire stream, since the regression testcase passes in a stream that
always returns a byte (an "infinite" stream).

The original code caught OutOfMemoryException and converted it to an IO exception, but that
did not work on some machines.  The new implementation, if it cannot use the fast reflection
path, reads a chunk and looks for a CR/CR LF within a reasonable length of data, and throws
the IO exception if it does not see one.


> [classlib][archive] org.apache.harmony.archive.tests.java.util.jar.ManifestTest fails
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6121
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6121
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: reported on Win XP during M9 testing
>            Reporter: Tim Ellison
>         Attachments: hy-6121-version2.patch, hy-6121.patch
>
>
> java.lang.NullPointerException 
> 	at java.io.InputStream.read(InputStream.java:148) 
> 	at java.io.InputStream.read(InputStream.java:121) 
> 	at org.apache.harmony.luni.util.InputStreamExposer.expose(InputStreamExposer.java:118)

> 	at java.util.jar.Manifest.read(Manifest.java:208) 
> 	at org.apache.harmony.archive.tests.java.util.jar.ManifestTest.testRead(ManifestTest.java:420)

> 	at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message