harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Regis Xu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6090) [classlib][luni] - the SO_REUSEADDR's default value of ServerSocket should be true on Linux
Date Mon, 30 Mar 2009 10:00:50 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693710#action_12693710
] 

Regis Xu commented on HARMONY-6090:
-----------------------------------

ServerSocketTest should be fixed to:

Index: modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/net/ServerSocketTest.java
=====================================================================
--- modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/net/ServerSocketTest.java
+++ modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/net/ServerSocketTest.java
@@ -35,7 +35,7 @@ import java.net.UnknownHostException;
 import java.util.Date;
 import java.util.Properties;
 
-import org.apache.harmony.luni.net.PlainSocketImpl;
+import org.apache.harmony.luni.net.PlainServerSocketImpl;
 
 import tests.support.Support_Configuration;
 import tests.support.Support_Exec;
@@ -333,7 +333,7 @@ public class ServerSocketTest extends SocketTestCase {
 
     private static class MockSocketImplFactory implements SocketImplFactory {
         public SocketImpl createSocketImpl() {
-            return new PlainSocketImpl();
+            return new PlainServerSocketImpl();
         }
     }
 
after this patch, ServerSocketTest can pass on my linux machine.

> [classlib][luni] - the SO_REUSEADDR's default value of ServerSocket should be true on
Linux
> -------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6090
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6090
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Regis Xu
>            Assignee: Sean Qiu
>             Fix For: 5.0M9
>
>         Attachments: harmony-6090-v2.patch, HARMONY-6090.diff, harmony-6090.patch
>
>
> In Harmony, the SO_REUSEADDR's default value of ServerSocket is false on Linux, while
RI is true.
> according to spec, this  default value is undefined, but it's better following RI to
get better compatibility

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message