harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Jing Qin (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-6085) [eut][classlib][nio] - modKey in SelectorImpl should set the new index key to the changed selectionkey
Date Mon, 09 Feb 2009 09:50:59 GMT

     [ https://issues.apache.org/jira/browse/HARMONY-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Li Jing Qin updated HARMONY-6085:
---------------------------------

    Attachment: HARMONY-6085.diff

In the patch I do two things:
1. Apply the new index to the selection Key
2. Break the ensureCapacity into three part: Common, Read and Write.

Because it is unusual for one selector being interested in both READ and WRITE ops in one
time, these will help to save 2 System.arraycopy per selector action.

Would any one please to review it?

> [eut][classlib][nio] - modKey in SelectorImpl should set the new index key to the changed
selectionkey
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6085
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6085
>             Project: Harmony
>          Issue Type: Bug
>         Environment: linux
>            Reporter: Li Jing Qin
>         Attachments: HARMONY-6085.diff
>
>
> modKey do two things:
> 1. delkey
> 2. addKey
> When the old selectionKey is readded, new index which is returned from the addkey should
be set to this selectionkey. 
> If does not do so. two problems will occurred, during eut update test on the lunix
> 1. Delete the wrong selectionkey, which will cause the right selector.select() return
RESOURCE NOT READY. More over it will cause the test case try lots of time to get the resource.
> 2. ArrayIndexOutOfBounds because of the wrong index.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message