Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <925568811.1231762319555.JavaMail.jira@brutus>
Date: Mon, 12 Jan 2009 04:11:59 -0800 (PST)
From: "Alexey Varlamov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-6021) [java6][classlib][security] Policy
 getPermissions(ProtectionDomain) may return different type of
 PermissionCollection from RI
In-Reply-To: <1371509995.1226978984341.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-6021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662945#action_12662945 ] 

Alexey Varlamov commented on HARMONY-6021:
------------------------------------------

Sean, the API spec explicitly states: "If this operation is supported, the returned set of permissions must be a new mutable instance and it must support heterogeneous Permission types."
AFAIS the suggested patch favors some kinks of RI over the specification. This does not look good to me unless you have really strong argument. If someone needs to use extended permission classes, this is naturally done via Policy subclassing, so your reasoning is not convincing - do you agree?


> [java6][classlib][security] Policy getPermissions(ProtectionDomain) may return different type of PermissionCollection from RI
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6021
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6021
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Sean Qiu
>            Assignee: Sean Qiu
>             Fix For: 5.0M9
>
>         Attachments: HARMONY-6021.diff
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> ---------
>   Test
> ---------
> private static class MockPermission extends BasicPermission{
> public MockPermission(String name) { super(name); }
> public MockPermission(String name, String action) { super(name,action); }
> }
> static class MockPermissions extends PermissionCollection{
> private Vector<Permission> permissions = new Vector();
> @Override
> public void add(Permission permission) {
> if(this.isReadOnly()){ throw new java.lang.SecurityException(); }
> if(permission instanceof MockPermission){ permissions.add(permission); }
> }
> @Override
> public Enumeration<Permission> elements() { return permissions.elements(); }
> @Override
> public boolean implies(Permission permission) {
> if(permissions.size()==0){ return false; }
> if(permission instanceof MockPermission){
> for(Permission perm : permissions){
> if( perm.implies(permission)){ return true; }
> }
> }
> return false;
> }
> }
> public void testGetPermissions() throws Exception{ 
>     MockPermission read = new MockPermission("read"); 
>     MockPermission write = new MockPermission("write"); 
>     PermissionCollection readPC = new MockPermissions(); 
>     readPC.add(read); 
>     ProtectionDomain pd = new ProtectionDomain(null, null); 
>     TestProvider policy = new TestProvider(); 
>      policy.pc = readPC; 
>      PermissionCollection permissions = policy.getPermissions(pd); 
>      assertTrue(permissions instanceof MockPermissions); 
>      assertSame(permissions, readPC); 
>      assertTrue(permissions.implies(read));     
>      assertFalse(permissions.implies(write)); 
> }
> ----------------
> Description
> ----------------
> Harmony'll failed in this testcase since it returns a new Permissions instance rather than use the customized PermissionCollection.
> The new created Permissions have different implies contact which leads to the failures.
> It doesn't make sense to create a new Permissions here, since customer may extension the default permission and permission collection here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.