harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From x..@apache.org
Subject svn commit: r731875 - /harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp
Date Tue, 06 Jan 2009 08:24:43 GMT
Author: xli
Date: Tue Jan  6 00:24:43 2009
New Revision: 731875

URL: http://svn.apache.org/viewvc?rev=731875&view=rev
Log:
Modified comments for HARMONY-6020 and r731515

Modified:
    harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp

Modified: harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp
URL: http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp?rev=731875&r1=731874&r2=731875&view=diff
==============================================================================
--- harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp (original)
+++ harmony/enhanced/drlvm/trunk/vm/vmcore/src/jit/jit_runtime_support.cpp Tue Jan  6 00:24:43
2009
@@ -1287,11 +1287,11 @@
 static void *rth_newarray_withresolve(Class_Handle klass, unsigned cp_idx, unsigned arraySize)
{
     ASSERT_THROW_AREA;
     
-    //resolve and init object class
+    //resolve object class (newarray does not require initializing the element class)
     Class* objClass = resolveClass(klass, cp_idx, false);
+    // following initialize() is commented, see details in HARMONY-6020. Basically, VM spec
$2.17.4 
+    // does not say the creation of an array of type T needs iniatializing T.
     //initializeClass(objClass);
-    //Spec does not require objClass be inited here, 
-    //Removing the initializeClass can pass the circular class init test cases in HARMONY-6020
     assert(!objClass->is_primitive());
 
     void* res = NULL;



Mime
View raw message