harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6059) [classlib][luni] jar URL is created with wrong protocol for URLStreamHandler
Date Sun, 18 Jan 2009 07:28:59 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664933#action_12664933
] 

Nathan Beyer commented on HARMONY-6059:
---------------------------------------

Did anyone try the new test that was added with this patch on a Windows OS?

I'm getting a failure from the following line -
assertEquals("Failed", BASE.toString()+SEP+"lf.jar!"+SEP+"swt.dll", res.getFile());

The error message is as follows - 
Failed expected:<...5Ctests%5Cjava%5Cnet[\lf.jar!\]swt.dll> but was:<...5Ctests%5Cjava%5Cnet[/lf.jar!/]swt.dll>

The field 'res' is a java.net.URL, so wouldn't the path separator's be normalized to '/',
instead of the OS-specific separator?

> [classlib][luni] jar URL is created with wrong protocol for URLStreamHandler
> ----------------------------------------------------------------------------
>
>                 Key: HARMONY-6059
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6059
>             Project: Harmony
>          Issue Type: Bug
>         Environment: vm which is above java6 is required
>            Reporter: Li Jing Qin
>            Priority: Minor
>             Fix For: 5.0M9
>
>         Attachments: HARMONY-6059.diff, HARMONY-6059v2.diff, lf.jar
>
>
> From the spec: "Any URL that ends with a '/' is assumed to refer to a directory. Otherwise,
the URL is assumed to refer to a JAR file which will be downloaded and opened as needed".
> So what I have done follows:
> 1. specified the URLStreamHandler to the jar, not the protocol as before
> 2. Add the test case to the test-impl
> 3. Because the I have add the a class file to the lf.jar, the size of jar file is increased.
So the test size case int the JarURLConnectionTest fail. I have changed the test case.
> 4. The reason that the vm above java6 is required is because the class file I have added
to the lf.jar is compiled under the java 6.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message