Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <2072221125.1229595284378.JavaMail.jira@brutus>
Date: Thu, 18 Dec 2008 02:14:44 -0800 (PST)
From: "Regis Xu (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Updated: (HARMONY-6052) [classlib][luni] remove platform
 specific code in socket.c::pollSelectRead
In-Reply-To: <1436098416.1229503124316.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HARMONY-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu updated HARMONY-6052:
------------------------------

    Attachment: HARMONY-6052.diff

This patch remove the specific code for win32 and make select_read on Windows has the same behavior as Linux

Anyone want to try it?

> [classlib][luni] remove platform specific code in socket.c::pollSelectRead
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6052
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6052
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Regis Xu
>             Fix For: 5.0M9
>
>         Attachments: HARMONY-6052.diff
>
>
> in socket.c::pollSelectRead, there are some codes like:
> #if defined(WIN32)
> ....
> #else
> ....
> #endif
> It seems hysock_select_read has different behaviors between Windows and Linux, (maybe return value means different things?)
> I think these platform specific codes could be move to portlib and make socket.c more clear.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.