Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 46318 invoked from network); 22 Dec 2008 03:26:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Dec 2008 03:26:05 -0000 Received: (qmail 6646 invoked by uid 500); 22 Dec 2008 03:26:05 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 6625 invoked by uid 500); 22 Dec 2008 03:26:05 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 6611 invoked by uid 99); 22 Dec 2008 03:26:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 21 Dec 2008 19:26:05 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Dec 2008 03:26:04 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 57FD8234C462 for ; Sun, 21 Dec 2008 19:25:44 -0800 (PST) Message-ID: <145911249.1229916344359.JavaMail.jira@brutus> Date: Sun, 21 Dec 2008 19:25:44 -0800 (PST) From: "Tony Wu (JIRA)" To: commits@harmony.apache.org Subject: [jira] Resolved: (HARMONY-6043) [classlib] [security] UnresolvedPermission.equals(Object) doesn't works well In-Reply-To: <359579868.1229063324352.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Wu resolved HARMONY-6043. ------------------------------ Resolution: Fixed 2nd patch applied at r728589 with handling to NPE. Thanks Kevin. Please verify if it fixes as you expected. > [classlib] [security] UnresolvedPermission.equals(Object) doesn't works well > ---------------------------------------------------------------------------- > > Key: HARMONY-6043 > URL: https://issues.apache.org/jira/browse/HARMONY-6043 > Project: Harmony > Issue Type: Bug > Components: Classlib > Affects Versions: 5.0M8 > Reporter: Kevin Zhou > Assignee: Tony Wu > Fix For: 5.0M9 > > Attachments: HARMONY-6043.diff, HARMONY-6043v2.diff > > Original Estimate: 24h > Remaining Estimate: 24h > > Given a test case[1], RI works well while HARMONY fails. > [1] UnresolvedPermissionTest > public class UnresolvedPermissionTest extends TestCase { > public static final String type = "java.util.PropertyPermission"; > public static final String name = "os.name"; > public static final String action = "write,read"; > public void test_Scenario0() { > UnresolvedPermission up1 = new UnresolvedPermission(type, name, action, > null); > UnresolvedPermission up2 = new UnresolvedPermission(type, name, action, > null); > assertEquals(up1, up2); > } > public void test_Scenario1() { > UnresolvedPermission up1 = new UnresolvedPermission(type, name, action, > null); > UnresolvedPermission up2 = new UnresolvedPermission(type, name, action, > new java.security.cert.Certificate[0]); > assertFalse(up1.equals(up2)); > } > public void test_Scenario2() { > UnresolvedPermission up1 = new UnresolvedPermission(type, name, action, > null); > UnresolvedPermission up2 = new UnresolvedPermission(type, name, action, > new java.security.cert.Certificate[2]); > assertFalse(up1.equals(up2)); > } > public void test_Scenario3() { > UnresolvedPermission up1 = new UnresolvedPermission(type, name, action, > new java.security.cert.Certificate[0]); > UnresolvedPermission up2 = new UnresolvedPermission(type, name, action, > new java.security.cert.Certificate[0]); > assertEquals(up1, up2); > } > public void test_Scenario4() { > UnresolvedPermission up1 = new UnresolvedPermission(type, name, action, > new java.security.cert.Certificate[0]); > UnresolvedPermission up2 = new UnresolvedPermission(type, name, action, > new java.security.cert.Certificate[2]); > assertFalse(up1.equals(up2)); > } > public void test_Scenario5() { > UnresolvedPermission up1 = new UnresolvedPermission(type, name, action, > new java.security.cert.Certificate[2]); > UnresolvedPermission up2 = new UnresolvedPermission(type, name, action, > new java.security.cert.Certificate[2]); > try { > up1.equals(up2); > fail("should throw NullPointerException"); > } catch (NullPointerException e) { > // Expected > } > } > public void test_Scenario6() { > UnresolvedPermission up1 = new UnresolvedPermission(type, name, action, > new java.security.cert.Certificate[2]); > UnresolvedPermission up2 = new UnresolvedPermission(type, name, action, > new java.security.cert.Certificate[5]); > assertFalse(up1.equals(up2)); > } > } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.