harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Wu (JIRA)" <j...@apache.org>
Subject [jira] Created: (HARMONY-6046) [classlib][security]Is it necessary to do toUpperCase in some security classes such as AttributeTypeAndValue?
Date Mon, 15 Dec 2008 03:43:44 GMT
[classlib][security]Is it necessary to do toUpperCase in some security classes such as AttributeTypeAndValue?
-------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-6046
                 URL: https://issues.apache.org/jira/browse/HARMONY-6046
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Tony Wu
            Priority: Trivial


tonywu@apache.org wrote:
> @@ -311,7 +312,7 @@
>              buf.append('=');
>              if (value.escapedString == value.getHexString()) {
>                  //FIXME all chars in upper case
> -                buf.append(value.getHexString().toUpperCase());
> +                buf.append(Util.toUpperCase(value.getHexString()));
>              } else if (value.escapedString.length() != value.rawString.length()) {
>                  // was escaped
>                  value.appendQEString(buf);

Seems odd in the first place to have converted the value to a hex string
with the wrong capitalization, then create a new string with the right
capitalization.

What would break if we changed the impl of getHexString() to return caps
rather than optimize the toUpperCase()?

x501/AttributeTypeAndValue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message