harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-6034) [classlib] [luni] Should Improve File System Exception Messages
Date Tue, 09 Dec 2008 12:56:44 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654788#action_12654788
] 

Tim Ellison commented on HARMONY-6034:
--------------------------------------

The patch [1] is not safe, because hyfile_error_message() does not isolate the error to the
current thread.
More on the dev list.

[1] https://issues.apache.org/jira/secure/attachment/12395634/HARMONY-6034.diff

> [classlib] [luni] Should Improve File System Exception Messages
> ---------------------------------------------------------------
>
>                 Key: HARMONY-6034
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6034
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Kevin Zhou
>             Fix For: 5.0M9
>
>         Attachments: HARMONY-6034.diff
>
>
> Given a test scenario [1] where "t:" is a mapped drive letter to which the current user
only has R+E access but doesn't have W acess.
> Conduct this on RI [2] and HARMONY [3]. Obviously, RI return a FileNotFoundException
with a "Access is denied" message while HARMONY does not provide information as to why the
file is not found. This also occurs when the corresponding file doesn't exist, RI will throw
FNF with "system fails to find ...".
> I think there is a difference in information returned that makes it a bit easier to understand
why the FNF Exception is occurring. 
> Should we improve this?
> [1] 
>     public static void main(String[] args) {
>         try {
>             File f = new File("t:/temp.file");
>             if (f.exists()) {
>                 System.out.println("File " + f.getAbsolutePath() + " exists");
>             }
>             FileOutputStream fos = new FileOutputStream(f);
>             fos.write("Hello, World!".getBytes());
>             fos.close();
>         } catch (FileNotFoundException fnfe) {
>             fnfe.printStackTrace(System.err);
>         } catch (Throwable t) {
>             t.printStackTrace(System.err);
>         }
>     }
> [2] Output from a FileNotFoundException on RI:
> java.io.FileNotFoundException: t:/temp.file (Access is denied)
> at java.io.FileOutputStream.open(Native Method)
> at java.io.FileOutputStream.<init>(FileOutputStream.java:201)
> at java.io.FileOutputStream.<init>(FileOutputStream.java:153)
> at test.Main.main(Main.java:23)
> [3] Output from a FileNotFoundException on HARMONY:
> java.io.FileNotFoundException: t:/temp.file
> at java.io.FileOutputStream.<init>(Unknown Source)
> at java.io.FileOutputStream.<init>(Unknown Source)
> at test.Main.main(Main.java:23)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message