Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <1382780311.1227756404286.JavaMail.jira@brutus>
Date: Wed, 26 Nov 2008 19:26:44 -0800 (PST)
From: "Sean Qiu (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Resolved: (HARMONY-6014) [classlib][luni]
 BufferedInputStream can not be closed in another thread
In-Reply-To: <1772064247.1226459984336.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HARMONY-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Qiu resolved HARMONY-6014.
-------------------------------

    Resolution: Fixed

But it works :-)

Applied at r721075, please verify if it works as expected.

> [classlib][luni] BufferedInputStream can not be closed in another thread
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-6014
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6014
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 5.0M7
>            Reporter: Kevin Zhou
>            Assignee: Sean Qiu
>             Fix For: 5.0M8
>
>         Attachments: HARMONY-6014.diff, stream.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Give the following test scenario [1], it start BufferedInputStream object in the main thread, and try to close it in another thread.
> HARMONY fails to close it since the main thread can still read bytes from the buffer.
> [1] 
> public void test_BufferedInputStream_close() {
>         InputStream inputStream = new InputStream() {
>             Object lock = new Object();
>             public int read() {
>                 return 1;
>             }
>             public int read(byte[] buf, int offset, int length) {
>                 synchronized (lock) {
>                     try {
>                         lock.wait(3000);
>                     } catch (InterruptedException e) {
>                         // Ignore
>                     }
>                 }
>                 return 1;
>             }
>             public void close() {
>                 synchronized (lock) {
>                     lock.notifyAll();
>                 }
>             }
>         };
>         final BufferedInputStream buffer = new BufferedInputStream(inputStream);
>         Runnable runnable = new Runnable() {
>             public void run() {
>                 try {
>                     Thread.sleep(1000);
>                     buffer.close();
>                 } catch (Exception e) {
>                     // Ignored
>                 }
>             }
>         };
>         new Thread(runnable).start();
>         try {
>             buffer.read(new byte[100], 0, 99);
>             fail("Should throw IOException");
>         } catch (IOException e) {
>             // Expected
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.