Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <1284084513.1220917064424.JavaMail.jira@brutus>
Date: Mon, 8 Sep 2008 16:37:44 -0700 (PDT)
From: "Nathan Beyer (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-5932) [classlib][sql] Can
 BaseRowSet.clone() be removed?
In-Reply-To: <1821092450.1217876084345.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HARMONY-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629336#action_12629336 ] 

Nathan Beyer commented on HARMONY-5932:
---------------------------------------

Log a new issue for that, as I believe this is the correct change. Even the spec for java se 6 indicates that this class doesn't implement clone [1]. The failing tests are either bad or the subclasses of BaseRowSet aren't implementing clone. This is an abstract class after all.

[1] http://java.sun.com/javase/6/docs/api/javax/sql/rowset/BaseRowSet.html

> [classlib][sql] Can BaseRowSet.clone() be removed?
> --------------------------------------------------
>
>                 Key: HARMONY-5932
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5932
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M6
>         Environment: All SQL M6
>            Reporter: Andrew Cornwall
>            Assignee: Sean Qiu
>            Priority: Minor
>         Attachments: HARMONY-5932.diff
>
>
> The class BaseRowSet has an implementation of clone() which does the following:
>     public BaseRowSet clone() throws CloneNotSupportedException{
>         BaseRowSet result = (BaseRowSet) super.clone();        
>         return result;
>         
>     }
> Is there any reason this method can't be removed so BaseRowSet inherits Object.clone() instead? The spec explicitly says clone() is inherited from Object, so the cast to BaseRowSet seems unnecessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.