harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao-Feng Li (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5360) [drlvm][thread] Suspend enable / disable mismatch in jthread function.
Date Thu, 04 Sep 2008 01:21:44 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628223#action_12628223
] 

Xiao-Feng Li commented on HARMONY-5360:
---------------------------------------

I am confused. :)

The issue says:
  "Function jthread_throw_exception should be called in suspend disable mode only. "

But the code in jthread_throw_exception() has:
   "assert(hythread_is_suspend_enabled()); "

This is an obvious contradiction. What is the problem??

I guess we can think about it in the exception-throwing semantics, whether it "should be"
enabled or disabled mode. And even if it should be enabled, an assertion does not really ensure
that. 

Thanks.

> [drlvm][thread] Suspend enable / disable mismatch in jthread function.
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-5360
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5360
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Pavel Afremov
>            Priority: Minor
>
> Suspend enable / disable mismatch in jthread function.
> I found following bug during ...\vm\vmcore\src\thread\thread_java_monitors.cpp code review.
> Function jthread_throw_exception should be called in suspend disable mode only. But it
can be called form jthread_monitor_exit, which can works in suspend disable and in suspend
enable mode.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message