harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5956) [classlib][pack200] Fix warnings
Date Thu, 28 Aug 2008 09:57:44 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626506#action_12626506
] 

Sian January commented on HARMONY-5956:
---------------------------------------

Hi Aleksey,

I don't agree with the changes to the classes in the .pack200 package in this patch because
that's ongoing development and the local variables that you've deleted are there because they
will be needed as development continues.

For the other classes it would be better if you deleted the code rather than commented it
out because it's not very neat to have lots of commented-out code around.  Would you be able
to make these changes and re-create the patch?

Thanks.


> [classlib][pack200] Fix warnings
> --------------------------------
>
>                 Key: HARMONY-5956
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5956
>             Project: Harmony
>          Issue Type: Improvement
>            Reporter: Aleksey Shipilev
>            Assignee: Sian January
>            Priority: Trivial
>         Attachments: pack200-warnings-v1.patch
>
>
> This patch fixes the warnings in pack200

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message