Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 24205 invoked from network); 8 Jul 2008 11:03:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Jul 2008 11:03:31 -0000 Received: (qmail 40176 invoked by uid 500); 8 Jul 2008 11:03:31 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 40075 invoked by uid 500); 8 Jul 2008 11:03:31 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 40066 invoked by uid 99); 8 Jul 2008 11:03:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2008 04:03:31 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jul 2008 11:02:47 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id E97C5234C15A for ; Tue, 8 Jul 2008 04:02:39 -0700 (PDT) Message-ID: <644657042.1215514959953.JavaMail.jira@brutus> Date: Tue, 8 Jul 2008 04:02:39 -0700 (PDT) From: "Sian January (JIRA)" To: commits@harmony.apache.org Subject: [jira] Assigned: (HARMONY-5899) [classlib][pack200] ByteCode.equals() can be optimized In-Reply-To: <1615420454.1215450991652.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HARMONY-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sian January reassigned HARMONY-5899: ------------------------------------- Assignee: Sian January > [classlib][pack200] ByteCode.equals() can be optimized > ------------------------------------------------------ > > Key: HARMONY-5899 > URL: https://issues.apache.org/jira/browse/HARMONY-5899 > Project: Harmony > Issue Type: Improvement > Components: Classlib > Affects Versions: 5.0M6 > Environment: Pack200 HEAD > Reporter: Andrew Cornwall > Assignee: Sian January > Attachments: main.patch > > > Now that HARMONY-5889 has been incorporated, the .equals() method for ByteCode can be simplified. This leads to some performance increase. > I've also modified the hashCode() method. It now leads to fewer collisions. Now there are as few as if Object.hashCode() were used instead. (I didn't use Object.hashCode() because the abstract hashCode() in ClassFileEntry means I'd have to put a helper method in ClassFileEntry - and if the code in ByteCode is just as fast, why do that?) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.