harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Cornwall (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-5902) [classlib][pack200] ClassConstantPool overuses ArrayLists
Date Wed, 09 Jul 2008 16:13:31 GMT

    [ https://issues.apache.org/jira/browse/HARMONY-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612170#action_12612170

Andrew Cornwall commented on HARMONY-5902:

In theory it will create a little less garbage to use ArrayList.get instead of an iterator
- and since addNested is called repeatedly, that means less time overall, since that garbage
needs to be collected. But I think Aleksey's patch is even better, so I'm happy to go with

> [classlib][pack200] ClassConstantPool overuses ArrayLists
> ---------------------------------------------------------
>                 Key: HARMONY-5902
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5902
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M6
>         Environment: Pack200 HEAD
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>            Priority: Minor
>             Fix For: 5.0M7
>         Attachments: main.patch, pack200-addnested-v1.patch
> The class ClassConstantPool uses ArrayList in places where it should use arrays. This
patch fixes one of the most egregious offenders.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message